Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtbackup: allow exiting if failing early #16726

Closed
wants to merge 1 commit into from
Closed

vtbackup: allow exiting if failing early #16726

wants to merge 1 commit into from

Conversation

mattrobenolt
Copy link
Contributor

The control flow in here relies on panic'ing and recovering from that panic.

Exiting the process ends up being blocked on this defer block before the panic recovery handler if we exit before servenv.ExitChan is created. We're then ultimately blocking forever and require a kill -9 while we're trying to write into a nil channel.

This is ultimately becuase we start up servenv.RunDefault() in a goroutine, and servenv.ExitChan ends up being created within that, so it's possible we are trying to exit before the channel is created.

Related Issue(s)

None

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

None

@mattrobenolt
vtbackup: allow exiting if failing early
5340848 
The control flow in here relies on panic'ing and recovering from that
panic.

Exiting the process ends up being blocked on this defer block before the
panic recovery handler if we exit before `servenv.ExitChan` is created.
We're then ultimately blocking forever and require a kill -9 while we're
trying to write into a nil channel.

This is ultimately becuase we start up `servenv.RunDefault()` in a
goroutine, and `servenv.ExitChan` ends up being created within that, so
it's possible we are trying to exit before the channel is created.

Signed-off-by: Matt Robenolt <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 6, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 6, 2024
@mattrobenolt
Copy link
Contributor Author

Oops, where I sourced this patch from was a branch not on main, this appears to be fine on main.

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (5ced946) to head (5340848).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/cmd/vtbackup/cli/vtbackup.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16726      +/-   ##
==========================================
- Coverage   68.92%   68.91%   -0.01%     
==========================================
  Files        1565     1565              
  Lines      201682   201682              
==========================================
- Hits       139010   138997      -13     
- Misses      62672    62685      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mattrobenolt